Fixing sizing and position issues with Math.floor for dropdown #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing this library, I found that removing the Math.floor would get the correct size of the parent component, whereas with it would end up short in many cases both for width and left specifically
|
I have to stick to a design where the dropdown list and container list need to be synchronized on the same border, I never found the solution with props. When researching in the library I discovered the same thing as @KalebLenfest, the Usually with After the change, remove Please accept the change sent by @KalebLenfest , thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing this library, I found that removing the Math.floor would get the correct size of the parent component, whereas with it would end up short in many cases both for width and left specifically